From c606f6b95f8dd456547dc6d5b8621dacc92e5421 Mon Sep 17 00:00:00 2001 From: Stefano Pigozzi Date: Sun, 28 Apr 2024 11:35:28 +0200 Subject: [PATCH] Do not track the `MonsterType` in `SacrificeStone`, so that a monster can have multiple It's not a big performance cost anyways --- entities/sacrifice_stone.gd | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/entities/sacrifice_stone.gd b/entities/sacrifice_stone.gd index c063b5a..52c94e6 100644 --- a/entities/sacrifice_stone.gd +++ b/entities/sacrifice_stone.gd @@ -7,7 +7,6 @@ signal sacrifice_changed(entity: PhysicsBody2D, type: Enums.MonsterType) var current_monster: PhysicsBody2D -var current_type: Enums.MonsterType = Enums.MonsterType.None func _on_tracked(body: PhysicsBody2D): @@ -18,12 +17,10 @@ func _on_tracked(body: PhysicsBody2D): var types: Array = body.find_children("*", "Sacrificable", false, false) for type in types: current_monster = body - current_type = type.type - sacrifice_changed.emit(current_monster, current_type) + sacrifice_changed.emit(current_monster) break func _on_untracked(body: PhysicsBody2D): if body == current_monster: current_monster = null - current_type = Enums.MonsterType.None - sacrifice_changed.emit(current_monster, current_type) + sacrifice_changed.emit(current_monster)