From 8e4f115d90a223c4966ffcd7bd41246188b72fdd Mon Sep 17 00:00:00 2001
From: Stefano Pigozzi <ste.pigozzi@gmail.com>
Date: Mon, 8 Jun 2020 02:55:59 +0200
Subject: [PATCH] Optimize _read_tile_block (10s gain!)

---
 lihzahrd/world.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lihzahrd/world.py b/lihzahrd/world.py
index ef2e601..6b289a6 100644
--- a/lihzahrd/world.py
+++ b/lihzahrd/world.py
@@ -240,7 +240,7 @@ class World:
         self.shadow_orbs = value
 
     @staticmethod
-    def _read_tile_block(fr: FileReader, tileframeimportant) -> List:
+    def _read_tile_block(fr: FileReader, tileframeimportant) -> Tuple[Tile, int]:
         # Once again, this code is a mess
         flags1 = fr.bits()
         has_block = flags1[1]
@@ -320,7 +320,7 @@ class World:
             multiply_by = 1
         # Create tile
         tile = Tile(block=block, wall=wall, liquid=liquid, wiring=wiring)
-        return [tile] * multiply_by
+        return tile, multiply_by
 
     @property
     def is_classic(self):
@@ -351,8 +351,10 @@ class World:
         while tm.size.x < world_size.x:
             column = []
             while len(column) < world_size.y:
-                readtiles = cls._read_tile_block(f, tileframeimportant)
-                column = [*column, *readtiles]
+                tile, multiply_by = cls._read_tile_block(f, tileframeimportant)
+                for _ in range(multiply_by):
+                    # This works by reference, and stops working if write support is added
+                    column.append(tile)
             tm.add_column(column)
         return tm