steffo/sophon
steffo/sophon
1
Fork 0
mirror of https://github.com/Steffo99/sophon.git synced 2024-12-22 14:54:22 +00:00
Code Activity

🐛 Fix NoneSerializer being used in actions

Browse source
This commit is contained in:
Steffo 2021-10-20 21:34:06 +02:00
parent 7c8dd8383c
commit 8df2394523
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
backend/sophon/core/views.py
View file

@ -207,6 +207,12 @@ class ResearchGroupViewSet(WriteSophonViewSet):
"owner": self.request.user, "owner": self.request.user,
} }
def get_custom_serializer_classes(self):
if self.action in ["join", "leave"]:
return self.get_object().get_access_serializer(self.request.user)
else:
return serializers.NoneSerializer
@action(detail=True, methods=["post"], name="Join group") @action(detail=True, methods=["post"], name="Join group")
def join(self, request, pk) -> Response: def join(self, request, pk) -> Response:
group = models.ResearchGroup.objects.get(pk=pk) group = models.ResearchGroup.objects.get(pk=pk)

8
backend/sophon/notebooks/views.py
View file

@ -8,7 +8,7 @@ from rest_framework.request import Request
from rest_framework.response import Response from rest_framework.response import Response
from sophon.core.models import ResearchGroup from sophon.core.models import ResearchGroup
from sophon.core.serializers import dynamic_serializer from sophon.core.serializers import dynamic_serializer, NoneSerializer
from sophon.core.views import SophonGroupViewSet from sophon.core.views import SophonGroupViewSet
from sophon.notebooks.models import Notebook from sophon.notebooks.models import Notebook
from sophon.projects.models import ResearchProject from sophon.projects.models import ResearchProject
@ -18,6 +18,12 @@ class NotebooksViewSet(SophonGroupViewSet, metaclass=abc.ABCMeta):
def get_group_from_serializer(self, serializer) -> ResearchGroup: def get_group_from_serializer(self, serializer) -> ResearchGroup:
return serializer.validated_data["project"].group return serializer.validated_data["project"].group
def get_custom_serializer_classes(self):
if self.action in ["sync", "start", "lock", "unlock", "stop"]:
return self.get_object().get_access_serializer(self.request.user)
else:
return NoneSerializer
@action(["PATCH"], detail=True) @action(["PATCH"], detail=True)
def sync(self, request: Request, **kwargs): def sync(self, request: Request, **kwargs):
""" """