unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

w1: Constify struct w1_family_ops

Browse source 
The fops field in the w1_family struct is never modified. Make it const
to indicate that. Constifying the pointer makes it possible for drivers
to declare static w1_family_ops structs const, which in turn will allow
the compiler to put it in read-only memory.

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Link: https://lore.kernel.org/r/20201004193202.4044-2-rikard.falkeborn@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Rikard Falkeborn 2020-10-04 21:32:00 +02:00 committed by Greg Kroah-Hartman
parent 9f126c56b9
commit 07f8569fbe
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/w1/w1.c
View file

@ -613,7 +613,7 @@ static int w1_uevent(struct device *dev, struct kobj_uevent_env *env)
static int w1_family_notify(unsigned long action, struct w1_slave *sl)
{
struct w1_family_ops *fops;
const struct w1_family_ops *fops;
int err;
fops = sl->family->fops;

2
include/linux/w1.h
View file

@ -269,7 +269,7 @@ struct w1_family {
struct list_head family_entry;
u8 fid;
struct w1_family_ops *fops;
const struct w1_family_ops *fops;
const struct of_device_id *of_match_table;