unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

ARM: bL_switcher: filter CPU hotplug requests when the switcher is active

Browse source 
Trying to support both the switcher and CPU hotplug at the same time
is tricky due to ambiguous semantics.  So let's at least prevent users
from messing around with those logical CPUs the switcher has removed
and those which were not active when the switcher was activated.

Signed-off-by: Nicolas Pitre <nico@linaro.org>
This commit is contained in:
Nicolas Pitre 2012-11-26 22:48:55 -05:00
parent 38c35d4f2e
commit 2726143514
1 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
arch/arm/common/bL_switcher.c
View file

@ -554,6 +554,26 @@ static int __init bL_switcher_sysfs_init(void)
#endif /* CONFIG_SYSFS */ #endif /* CONFIG_SYSFS */
/*
* Veto any CPU hotplug operation on those CPUs we've removed
* while the switcher is active.
* We're just not ready to deal with that given the trickery involved.
*/
static int bL_switcher_hotplug_callback(struct notifier_block *nfb,
unsigned long action, void *hcpu)
{
if (bL_switcher_active) {
int pairing = bL_switcher_cpu_pairing[(unsigned long)hcpu];
switch (action & 0xf) {
case CPU_UP_PREPARE:
case CPU_DOWN_PREPARE:
if (pairing == -1)
return NOTIFY_BAD;
}
}
return NOTIFY_DONE;
}
static bool no_bL_switcher; static bool no_bL_switcher;
core_param(no_bL_switcher, no_bL_switcher, bool, 0644); core_param(no_bL_switcher, no_bL_switcher, bool, 0644);
@ -566,6 +586,8 @@ static int __init bL_switcher_init(void)
return -EINVAL; return -EINVAL;
} }
cpu_notifier(bL_switcher_hotplug_callback, 0);
if (!no_bL_switcher) { if (!no_bL_switcher) {
ret = bL_switcher_enable(); ret = bL_switcher_enable();
if (ret) if (ret)