block: add __must_check for *add_disk*() callers
Now that we have done a spring cleaning on all drivers and added error checking / handling, let's keep it that way and ensure no new drivers fail to stick with it. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20211110002949.999380-1-mcgrof@kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
parent
ecaf97f474
commit
278167fd2f
2 changed files with 6 additions and 6 deletions
|
@ -394,8 +394,8 @@ static void disk_scan_partitions(struct gendisk *disk)
|
||||||
* This function registers the partitioning information in @disk
|
* This function registers the partitioning information in @disk
|
||||||
* with the kernel.
|
* with the kernel.
|
||||||
*/
|
*/
|
||||||
int device_add_disk(struct device *parent, struct gendisk *disk,
|
int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
|
||||||
const struct attribute_group **groups)
|
const struct attribute_group **groups)
|
||||||
|
|
||||||
{
|
{
|
||||||
struct device *ddev = disk_to_dev(disk);
|
struct device *ddev = disk_to_dev(disk);
|
||||||
|
@ -544,7 +544,7 @@ int device_add_disk(struct device *parent, struct gendisk *disk,
|
||||||
out_free_ext_minor:
|
out_free_ext_minor:
|
||||||
if (disk->major == BLOCK_EXT_MAJOR)
|
if (disk->major == BLOCK_EXT_MAJOR)
|
||||||
blk_free_ext_minor(disk->first_minor);
|
blk_free_ext_minor(disk->first_minor);
|
||||||
return WARN_ON_ONCE(ret); /* keep until all callers handle errors */
|
return ret;
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL(device_add_disk);
|
EXPORT_SYMBOL(device_add_disk);
|
||||||
|
|
||||||
|
|
|
@ -205,9 +205,9 @@ static inline dev_t disk_devt(struct gendisk *disk)
|
||||||
void disk_uevent(struct gendisk *disk, enum kobject_action action);
|
void disk_uevent(struct gendisk *disk, enum kobject_action action);
|
||||||
|
|
||||||
/* block/genhd.c */
|
/* block/genhd.c */
|
||||||
int device_add_disk(struct device *parent, struct gendisk *disk,
|
int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
|
||||||
const struct attribute_group **groups);
|
const struct attribute_group **groups);
|
||||||
static inline int add_disk(struct gendisk *disk)
|
static inline int __must_check add_disk(struct gendisk *disk)
|
||||||
{
|
{
|
||||||
return device_add_disk(NULL, disk, NULL);
|
return device_add_disk(NULL, disk, NULL);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue