[media] tda18271: properly report read errors in tda18271_get_id
Until now, if there is a read error in tda18271_get_id, the driver reports "Unknown device..." Instead, check the return value of tda18271_read_regs and display the appropriate error message. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
6b82e0cfc1
commit
351d18786e
1 changed files with 9 additions and 1 deletions
|
@ -1159,11 +1159,19 @@ static int tda18271_get_id(struct dvb_frontend *fe)
|
||||||
struct tda18271_priv *priv = fe->tuner_priv;
|
struct tda18271_priv *priv = fe->tuner_priv;
|
||||||
unsigned char *regs = priv->tda18271_regs;
|
unsigned char *regs = priv->tda18271_regs;
|
||||||
char *name;
|
char *name;
|
||||||
|
int ret;
|
||||||
|
|
||||||
mutex_lock(&priv->lock);
|
mutex_lock(&priv->lock);
|
||||||
tda18271_read_regs(fe);
|
ret = tda18271_read_regs(fe);
|
||||||
mutex_unlock(&priv->lock);
|
mutex_unlock(&priv->lock);
|
||||||
|
|
||||||
|
if (ret) {
|
||||||
|
tda_info("Error reading device ID @ %d-%04x, bailing out.\n",
|
||||||
|
i2c_adapter_id(priv->i2c_props.adap),
|
||||||
|
priv->i2c_props.addr);
|
||||||
|
return -EIO;
|
||||||
|
}
|
||||||
|
|
||||||
switch (regs[R_ID] & 0x7f) {
|
switch (regs[R_ID] & 0x7f) {
|
||||||
case 3:
|
case 3:
|
||||||
name = "TDA18271HD/C1";
|
name = "TDA18271HD/C1";
|
||||||
|
|
Loading…
Reference in a new issue