unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

scsi: mpi3mr: Improve wait logic while controller transitions to READY state

Browse source 
During controller transitioning to READY state, if the controller is found
in transient states ("becoming ready" or "reset requested"), driver waits
for 510 secs even if the controller transitions out of these states
early. This causes an unnecessary delay of 510 secs in the overall firmware
initialization sequence.

Poll the controller state periodically (every 100 milliseconds) while
waiting for the controller to come out of the mentioned transient
states. Once the controller transits out of the transient states, come out
of the wait loop.

Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
Link: https://lore.kernel.org/r/20240905102753.105310-5-ranjan.kumar@broadcom.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Ranjan Kumar 2024-09-05 15:57:52 +05:30 committed by Martin K. Petersen
parent 6e4c825f26
commit 4616a4b3cb
1 changed files with 11 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
drivers/scsi/mpi3mr/mpi3mr_fw.c
View file

@ -1384,26 +1384,23 @@ static int mpi3mr_bring_ioc_ready(struct mpi3mr_ioc *mrioc)
ioc_info(mrioc, "controller is in %s state during detection\n", ioc_info(mrioc, "controller is in %s state during detection\n",
mpi3mr_iocstate_name(ioc_state)); mpi3mr_iocstate_name(ioc_state));
if (ioc_state == MRIOC_STATE_BECOMING_READY || timeout = mrioc->ready_timeout * 10;
ioc_state == MRIOC_STATE_RESET_REQUESTED) {
timeout = mrioc->ready_timeout * 10; do {
do { ioc_state = mpi3mr_get_iocstate(mrioc);
msleep(100);
} while (--timeout); if (ioc_state != MRIOC_STATE_BECOMING_READY &&
ioc_state != MRIOC_STATE_RESET_REQUESTED)
break;
if (!pci_device_is_present(mrioc->pdev)) { if (!pci_device_is_present(mrioc->pdev)) {
mrioc->unrecoverable = 1; mrioc->unrecoverable = 1;
ioc_err(mrioc, ioc_err(mrioc, "controller is not present while waiting to reset\n");
"controller is not present while waiting to reset\n");
retval = -1;
goto out_device_not_present; goto out_device_not_present;
} }
ioc_state = mpi3mr_get_iocstate(mrioc); msleep(100);
ioc_info(mrioc, } while (--timeout);
"controller is in %s state after waiting to reset\n",
mpi3mr_iocstate_name(ioc_state));
}
if (ioc_state == MRIOC_STATE_READY) { if (ioc_state == MRIOC_STATE_READY) {
ioc_info(mrioc, "issuing message unit reset (MUR) to bring to reset state\n"); ioc_info(mrioc, "issuing message unit reset (MUR) to bring to reset state\n");