unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

Fix memory leak in posix_clock_open()

Browse source 
If the clk ops.open() function returns an error, we don't release the
pccontext we allocated for this clock.

Re-organize the code slightly to make it all more obvious.

Reported-by: Rohit Keshri <rkeshri@redhat.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Fixes: 60c6946675 ("posix-clock: introduce posix_clock_context concept")
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linuxfoundation.org>
This commit is contained in:
Linus Torvalds 2024-03-26 14:59:48 -07:00
parent 7033999ecd
commit 5b4cdd9c56
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
kernel/time/posix-clock.c
View file

@ -129,15 +129,17 @@ static int posix_clock_open(struct inode *inode, struct file *fp)
goto out; goto out;
} }
pccontext->clk = clk; pccontext->clk = clk;
fp->private_data = pccontext; if (clk->ops.open) {
if (clk->ops.open)
err = clk->ops.open(pccontext, fp->f_mode); err = clk->ops.open(pccontext, fp->f_mode);
else if (err) {
err = 0; kfree(pccontext);
goto out;
if (!err) { }
get_device(clk->dev);
} }
fp->private_data = pccontext;
get_device(clk->dev);
err = 0;
out: out:
up_read(&clk->rwsem); up_read(&clk->rwsem);
return err; return err;