unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

perf tools: Get rid of evlist__add_on_all_cpus()

Browse source 
The cpu and thread maps are properly handled in libperf now.  No need to
do it in the perf tools anymore.  Let's remove the logic.

Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20221003204647.1481128-4-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2022-10-03 13:46:45 -07:00 committed by Arnaldo Carvalho de Melo
parent 7e2450bb75
commit 60ea006f72
1 changed files with 2 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
tools/perf/util/evlist.c
View file

@ -268,28 +268,6 @@ int evlist__add_dummy(struct evlist *evlist)
return 0;
}
static void evlist__add_on_all_cpus(struct evlist *evlist, struct evsel *evsel)
{
evsel->core.system_wide = true;
/*
* All CPUs.
*
* Note perf_event_open() does not accept CPUs that are not online, so
* in fact this CPU list will include only all online CPUs.
*/
perf_cpu_map__put(evsel->core.own_cpus);
evsel->core.own_cpus = perf_cpu_map__new(NULL);
perf_cpu_map__put(evsel->core.cpus);
evsel->core.cpus = perf_cpu_map__get(evsel->core.own_cpus);
/* No threads */
perf_thread_map__put(evsel->core.threads);
evsel->core.threads = perf_thread_map__new_dummy();
evlist__add(evlist, evsel);
}
struct evsel *evlist__add_aux_dummy(struct evlist *evlist, bool system_wide)
{
struct evsel *evsel = evlist__dummy_event(evlist);
@ -302,14 +280,11 @@ struct evsel *evlist__add_aux_dummy(struct evlist *evlist, bool system_wide)
evsel->core.attr.exclude_hv = 1;
evsel->core.attr.freq = 0;
evsel->core.attr.sample_period = 1;
evsel->core.system_wide = system_wide;
evsel->no_aux_samples = true;
evsel->name = strdup("dummy:u");
if (system_wide)
evlist__add_on_all_cpus(evlist, evsel);
else
evlist__add(evlist, evsel);
evlist__add(evlist, evsel);
return evsel;
}