unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

maple_tree: mte_set_full() and mte_clear_full() clang-analyzer clean up

Browse source 
mte_set_full() and mte_clear_full() were incorrectly setting a pointer to
a value without returning a result.  Fix this by returning the modified
pointer to be use as necessary.  Also add a third function to return if
the bit is set or not.

Link: https://lore.kernel.org/lkml/20221026120029.12555-1-lukas.bulwahn@gmail.com/
Link: https://lkml.kernel.org/r/20221028144520.2776767-1-Liam.Howlett@oracle.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Liam Howlett 2022-10-28 14:45:34 +00:00 committed by Andrew Morton
parent 57e9cc50f4
commit 6e7ba8b5e2
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/maple_tree.c
View file

@ -323,14 +323,19 @@ static inline void *mte_safe_root(const struct maple_enode *node)
return (void *)((unsigned long)node & ~MAPLE_ROOT_NODE);
}
static inline void mte_set_full(const struct maple_enode *node)
static inline void *mte_set_full(const struct maple_enode *node)
{
node = (void *)((unsigned long)node & ~MAPLE_ENODE_NULL);
return (void *)((unsigned long)node & ~MAPLE_ENODE_NULL);
}
static inline void mte_clear_full(const struct maple_enode *node)
static inline void *mte_clear_full(const struct maple_enode *node)
{
node = (void *)((unsigned long)node | MAPLE_ENODE_NULL);
return (void *)((unsigned long)node | MAPLE_ENODE_NULL);
}
static inline bool mte_has_null(const struct maple_enode *node)
{
return (unsigned long)node & MAPLE_ENODE_NULL;
}
static inline bool ma_is_root(struct maple_node *node)