unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

reset: rzg2l-usbphy-ctrl: Convert to platform remove callback returning void

Browse source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/e75fb1af5c7df5fc4073a26a99ba88633503910d.1709674157.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
Uwe Kleine-König 2024-03-05 22:32:04 +01:00 committed by Philipp Zabel
parent b99e9c0961
commit 7f5aa02ad0
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/reset/reset-rzg2l-usbphy-ctrl.c
View file

@ -156,15 +156,13 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int rzg2l_usbphy_ctrl_remove(struct platform_device *pdev) static void rzg2l_usbphy_ctrl_remove(struct platform_device *pdev)
{ {
struct rzg2l_usbphy_ctrl_priv *priv = dev_get_drvdata(&pdev->dev); struct rzg2l_usbphy_ctrl_priv *priv = dev_get_drvdata(&pdev->dev);
pm_runtime_put(&pdev->dev); pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
reset_control_assert(priv->rstc); reset_control_assert(priv->rstc);
return 0;
} }
static struct platform_driver rzg2l_usbphy_ctrl_driver = { static struct platform_driver rzg2l_usbphy_ctrl_driver = {
@ -173,7 +171,7 @@ static struct platform_driver rzg2l_usbphy_ctrl_driver = {
.of_match_table = rzg2l_usbphy_ctrl_match_table, .of_match_table = rzg2l_usbphy_ctrl_match_table,
}, },
.probe = rzg2l_usbphy_ctrl_probe, .probe = rzg2l_usbphy_ctrl_probe,
.remove = rzg2l_usbphy_ctrl_remove, .remove_new = rzg2l_usbphy_ctrl_remove,
}; };
module_platform_driver(rzg2l_usbphy_ctrl_driver); module_platform_driver(rzg2l_usbphy_ctrl_driver);