unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

futex: Deduplicate cond_resched() invocation in futex_wake_op()

Browse source 
After pagefaulting in futex_wake_op() both branches do cond_resched()
before retry. Deduplicate it as compilers cannot figure it out themself.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Davidlohr Bueso <dbueso@suse.de>
Link: https://lore.kernel.org/r/9b2588c1fd33c91fb01c4e348a3b647ab2c8baab.1621258128.git.asml.silence@gmail.com
This commit is contained in:
Pavel Begunkov 2021-05-17 14:30:12 +01:00 committed by Thomas Gleixner
parent f4addd54b1
commit a82adc7650
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
kernel/futex.c
View file

@ -1728,12 +1728,9 @@ futex_wake_op(u32 __user *uaddr1, unsigned int flags, u32 __user *uaddr2,
return ret; return ret;
} }
if (!(flags & FLAGS_SHARED)) {
cond_resched();
goto retry_private;
}
cond_resched(); cond_resched();
if (!(flags & FLAGS_SHARED))
goto retry_private;
goto retry; goto retry;
} }