unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

clk: sunxi: usb: fix kernel-doc warnings

Browse source 
Move the function description comment to immediately above the
function implementation, the add function parameter descriptions to
prevent kernel-doc warnings:

clk-usb.c:80: warning: expecting prototype for sunxi_usb_clk_setup(). Prototype was for SUNXI_USB_MAX_SIZE() instead
clk-usb.c:91: warning: Function parameter or struct member 'node' not described in 'sunxi_usb_clk_setup'
clk-usb.c:91: warning: Function parameter or struct member 'data' not described in 'sunxi_usb_clk_setup'
clk-usb.c:91: warning: Function parameter or struct member 'lock' not described in 'sunxi_usb_clk_setup'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Emilio López <emilio@elopez.com.ar>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc:  <linux-clk@vger.kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc:  <linux-arm-kernel@lists.infradead.org>
Cc:  <linux-sunxi@lists.linux.dev>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20240121051858.17647-1-rdunlap@infradead.org
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
This commit is contained in:
Randy Dunlap 2024-01-20 21:18:57 -08:00 committed by Jernej Skrabec
parent cc61c9e597
commit aed6d71318
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/clk/sunxi/clk-usb.c
View file

@ -73,9 +73,6 @@ static const struct reset_control_ops sunxi_usb_reset_ops = {
.deassert = sunxi_usb_reset_deassert, .deassert = sunxi_usb_reset_deassert,
}; };
/**
* sunxi_usb_clk_setup() - Setup function for usb gate clocks
*/
#define SUNXI_USB_MAX_SIZE 32 #define SUNXI_USB_MAX_SIZE 32
@ -85,6 +82,12 @@ struct usb_clk_data {
bool reset_needs_clk; bool reset_needs_clk;
}; };
/**
* sunxi_usb_clk_setup() - Setup function for usb gate clocks
* @node: &struct device_node for the clock
* @data: &struct usb_clk_data for the clock
* @lock: spinlock for the clock
*/
static void __init sunxi_usb_clk_setup(struct device_node *node, static void __init sunxi_usb_clk_setup(struct device_node *node,
const struct usb_clk_data *data, const struct usb_clk_data *data,
spinlock_t *lock) spinlock_t *lock)