unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

tty: rfcomm: prefer array indexing over pointer arithmetic

Browse source 
Refactor the list_for_each_entry() loop of rfcomm_get_dev_list()
function to use array indexing instead of pointer arithmetic.

This way, the code is more readable and idiomatic.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Erick Archer <erick.archer@outlook.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This commit is contained in:
Erick Archer 2024-05-17 19:21:50 +02:00 committed by Luiz Augusto von Dentz
parent 7d2c7ddba6
commit b1c7cd6caa
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
net/bluetooth/rfcomm/tty.c
View file

@ -527,12 +527,12 @@ static int rfcomm_get_dev_list(void __user *arg)
list_for_each_entry(dev, &rfcomm_dev_list, list) { list_for_each_entry(dev, &rfcomm_dev_list, list) {
if (!tty_port_get(&dev->port)) if (!tty_port_get(&dev->port))
continue; continue;
(di + n)->id = dev->id; di[n].id = dev->id;
(di + n)->flags = dev->flags; di[n].flags = dev->flags;
(di + n)->state = dev->dlc->state; di[n].state = dev->dlc->state;
(di + n)->channel = dev->channel; di[n].channel = dev->channel;
bacpy(&(di + n)->src, &dev->src); bacpy(&di[n].src, &dev->src);
bacpy(&(di + n)->dst, &dev->dst); bacpy(&di[n].dst, &dev->dst);
tty_port_put(&dev->port); tty_port_put(&dev->port);
if (++n >= dev_num) if (++n >= dev_num)
break; break;