unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

Browse source 
CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
and users have no idea about the change in behaviour.

Let's remove the setting currently and could turn it
into a module parameter if it's really needed.

Suggested-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20190731155752.210602-9-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gao Xiang 2019-07-31 23:57:38 +08:00 committed by Greg Kroah-Hartman
parent 22ee1347a8
commit beb5f3c4a1
2 changed files with 2 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/erofs/Kconfig
View file

@ -78,15 +78,6 @@ config EROFS_FAULT_INJECTION
Test EROFS to inject faults such as ENOMEM, EIO, and so on.
If unsure, say N.
config EROFS_FS_IO_MAX_RETRIES
int "EROFS IO Maximum Retries"
depends on EROFS_FS
default "5"
help
Maximum retry count of IO Errors.
If unsure, leave the default value (5 retries, 6 IOs at most).
config EROFS_FS_ZIP
bool "EROFS Data Compresssion Support"
depends on EROFS_FS

8
drivers/staging/erofs/internal.h
View file

@ -279,6 +279,8 @@ static inline void z_erofs_exit_zip_subsystem(void) {}
#error erofs cannot be used in this platform
#endif
#define EROFS_IO_MAX_RETRIES_NOFAIL 5
#define ROOT_NID(sb) ((sb)->root_nid)
#define erofs_blknr(addr) ((addr) / EROFS_BLKSIZ)
@ -467,12 +469,6 @@ static inline void __submit_bio(struct bio *bio, unsigned int op,
submit_bio(bio);
}
#ifndef CONFIG_EROFS_FS_IO_MAX_RETRIES
#define EROFS_IO_MAX_RETRIES_NOFAIL 0
#else
#define EROFS_IO_MAX_RETRIES_NOFAIL CONFIG_EROFS_FS_IO_MAX_RETRIES
#endif
struct page *__erofs_get_meta_page(struct super_block *sb, erofs_blk_t blkaddr,
bool prio, bool nofail);