unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

lib/test_meminit: optimize do_kmem_cache_rcu_persistent() test

Browse source 
To make the test more robust, there are the following changes:
1. add a check for the return value of kmem_cache_alloc().
2. properly release the object `buf` on several error paths.
3. release the objects of `used_objects` if we never hit `saved_ptr`.
4. destroy the created cache by default.

Link: https://lkml.kernel.org/r/tencent_7CB95F1C3914BCE1CA4A61FF7C20E7CCB108@qq.com
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Marco Elver <elver@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Xiaoke Wang <xkernel.wang@foxmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Xiaoke Wang 2022-04-29 14:38:00 -07:00 committed by akpm
parent 11fb48961e
commit d4557fae77
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/test_meminit.c
View file

@ -279,13 +279,18 @@ static int __init do_kmem_cache_rcu_persistent(int size, int *total_failures)
c = kmem_cache_create("test_cache", size, size, SLAB_TYPESAFE_BY_RCU, c = kmem_cache_create("test_cache", size, size, SLAB_TYPESAFE_BY_RCU,
NULL); NULL);
buf = kmem_cache_alloc(c, GFP_KERNEL); buf = kmem_cache_alloc(c, GFP_KERNEL);
if (!buf)
goto out;
saved_ptr = buf; saved_ptr = buf;
fill_with_garbage(buf, size); fill_with_garbage(buf, size);
buf_contents = kmalloc(size, GFP_KERNEL); buf_contents = kmalloc(size, GFP_KERNEL);
if (!buf_contents) if (!buf_contents) {
kmem_cache_free(c, buf);
goto out; goto out;
}
used_objects = kmalloc_array(maxiter, sizeof(void *), GFP_KERNEL); used_objects = kmalloc_array(maxiter, sizeof(void *), GFP_KERNEL);
if (!used_objects) { if (!used_objects) {
kmem_cache_free(c, buf);
kfree(buf_contents); kfree(buf_contents);
goto out; goto out;
} }
@ -306,11 +311,14 @@ static int __init do_kmem_cache_rcu_persistent(int size, int *total_failures)
} }
} }
for (iter = 0; iter < maxiter; iter++)
kmem_cache_free(c, used_objects[iter]);
free_out: free_out:
kmem_cache_destroy(c);
kfree(buf_contents); kfree(buf_contents);
kfree(used_objects); kfree(used_objects);
out: out:
kmem_cache_destroy(c);
*total_failures += fail; *total_failures += fail;
return 1; return 1;
} }