unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

mfd: cros_ec: Simplify and clean-up cros_ec_dev_init()

Browse source 
Simplify cros_ec_dev_init() by the following changes:
- Get rid of label `failed_devreg`.
- Remove a redundant space and comment.
- Use `if (ret)` instead of `if (ret < 0)`.

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20240819102326.5235-1-tzungbi@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Tzung-Bi Shih 2024-08-19 18:23:26 +08:00 committed by Lee Jones
parent 607638b73c
commit dc98e25bc3
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/mfd/cros_ec_dev.c
View file

@ -353,22 +353,17 @@ static int __init cros_ec_dev_init(void)
{
int ret;
ret = class_register(&cros_class);
ret = class_register(&cros_class);
if (ret) {
pr_err(CROS_EC_DEV_NAME ": failed to register device class\n");
return ret;
}
/* Register the driver */
ret = platform_driver_register(&cros_ec_dev_driver);
if (ret < 0) {
if (ret) {
pr_warn(CROS_EC_DEV_NAME ": can't register driver: %d\n", ret);
goto failed_devreg;
class_unregister(&cros_class);
}
return 0;
failed_devreg:
class_unregister(&cros_class);
return ret;
}