unimore/kernel-hacking-2024-linux-steffo
unimore/kernel-hacking-2024-linux-steffo
1
Fork 0
Code Pull requests 5 Wiki Activity

leds: max5970: Make use of dev_err_probe()

Browse source 
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231214184050.1272848-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Andy Shevchenko 2023-12-14 20:40:10 +02:00 committed by Lee Jones
parent 6d63d05e26
commit e7baa5b437
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/leds/leds-max5970.c
View file

@ -62,7 +62,7 @@ static int max5970_led_probe(struct platform_device *pdev)
continue;
if (reg >= MAX5970_NUM_LEDS) {
dev_err(dev, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS);
dev_err_probe(dev, -EINVAL, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS);
continue;
}
@ -86,8 +86,7 @@ static int max5970_led_probe(struct platform_device *pdev)
ret = devm_led_classdev_register(dev, &ddata->cdev);
if (ret < 0) {
fwnode_handle_put(child);
dev_err(dev, "Failed to initialize LED %u\n", reg);
return ret;
return dev_err_probe(dev, ret, "Failed to initialize LED %u\n", reg);
}
}