5a1ccf0c72
This patch introduces a new USB quirk, USB_QUIRK_SHORT_SET_ADDRESS_REQ_TIMEOUT, which modifies the timeout value for the SET_ADDRESS request. The standard timeout for USB request/command is 5000 ms, as recommended in the USB 3.2 specification (section 9.2.6.1). However, certain scenarios, such as connecting devices through an APTIV hub, can lead to timeout errors when the device enumerates as full speed initially and later switches to high speed during chirp negotiation. In such cases, USB analyzer logs reveal that the bus suspends for 5 seconds due to incorrect chirp parsing and resumes only after two consecutive timeout errors trigger a hub driver reset. Packet(54) Dir(?) Full Speed J(997.100 us) Idle( 2.850 us) _______| Time Stamp(28 . 105 910 682) _______|_____________________________________________________________Ch0 Packet(55) Dir(?) Full Speed J(997.118 us) Idle( 2.850 us) _______| Time Stamp(28 . 106 910 632) _______|_____________________________________________________________Ch0 Packet(56) Dir(?) Full Speed J(399.650 us) Idle(222.582 us) _______| Time Stamp(28 . 107 910 600) _______|_____________________________________________________________Ch0 Packet(57) Dir Chirp J( 23.955 ms) Idle(115.169 ms) _______| Time Stamp(28 . 108 532 832) _______|_____________________________________________________________Ch0 Packet(58) Dir(?) Full Speed J (Suspend)( 5.347 sec) Idle( 5.366 us) _______| Time Stamp(28 . 247 657 600) _______|_____________________________________________________________Ch0 This 5-second delay in device enumeration is undesirable, particularly in automotive applications where quick enumeration is crucial (ideally within 3 seconds). The newly introduced quirks provide the flexibility to align with a 3-second time limit, as required in specific contexts like automotive applications. By reducing the SET_ADDRESS request timeout to 500 ms, the system can respond more swiftly to errors, initiate rapid recovery, and ensure efficient device enumeration. This change is vital for scenarios where rapid smartphone enumeration and screen projection are essential. To use the quirk, please write "vendor_id:product_id:p" to /sys/bus/usb/drivers/hub/module/parameter/quirks For example, echo "0x2c48:0x0132:p" > /sys/bus/usb/drivers/hub/module/parameters/quirks" Signed-off-by: Hardik Gajjar <hgajjar@de.adit-jv.com> Reviewed-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/20231027152029.104363-2-hgajjar@de.adit-jv.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
78 lines
2.4 KiB
C
78 lines
2.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* This file holds the definitions of quirks found in USB devices.
|
|
* Only quirks that affect the whole device, not an interface,
|
|
* belong here.
|
|
*/
|
|
|
|
#ifndef __LINUX_USB_QUIRKS_H
|
|
#define __LINUX_USB_QUIRKS_H
|
|
|
|
/* string descriptors must not be fetched using a 255-byte read */
|
|
#define USB_QUIRK_STRING_FETCH_255 BIT(0)
|
|
|
|
/* device can't resume correctly so reset it instead */
|
|
#define USB_QUIRK_RESET_RESUME BIT(1)
|
|
|
|
/* device can't handle Set-Interface requests */
|
|
#define USB_QUIRK_NO_SET_INTF BIT(2)
|
|
|
|
/* device can't handle its Configuration or Interface strings */
|
|
#define USB_QUIRK_CONFIG_INTF_STRINGS BIT(3)
|
|
|
|
/* device can't be reset(e.g morph devices), don't use reset */
|
|
#define USB_QUIRK_RESET BIT(4)
|
|
|
|
/* device has more interface descriptions than the bNumInterfaces count,
|
|
and can't handle talking to these interfaces */
|
|
#define USB_QUIRK_HONOR_BNUMINTERFACES BIT(5)
|
|
|
|
/* device needs a pause during initialization, after we read the device
|
|
descriptor */
|
|
#define USB_QUIRK_DELAY_INIT BIT(6)
|
|
|
|
/*
|
|
* For high speed and super speed interrupt endpoints, the USB 2.0 and
|
|
* USB 3.0 spec require the interval in microframes
|
|
* (1 microframe = 125 microseconds) to be calculated as
|
|
* interval = 2 ^ (bInterval-1).
|
|
*
|
|
* Devices with this quirk report their bInterval as the result of this
|
|
* calculation instead of the exponent variable used in the calculation.
|
|
*/
|
|
#define USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL BIT(7)
|
|
|
|
/* device can't handle device_qualifier descriptor requests */
|
|
#define USB_QUIRK_DEVICE_QUALIFIER BIT(8)
|
|
|
|
/* device generates spurious wakeup, ignore remote wakeup capability */
|
|
#define USB_QUIRK_IGNORE_REMOTE_WAKEUP BIT(9)
|
|
|
|
/* device can't handle Link Power Management */
|
|
#define USB_QUIRK_NO_LPM BIT(10)
|
|
|
|
/*
|
|
* Device reports its bInterval as linear frames instead of the
|
|
* USB 2.0 calculation.
|
|
*/
|
|
#define USB_QUIRK_LINEAR_FRAME_INTR_BINTERVAL BIT(11)
|
|
|
|
/*
|
|
* Device needs to be disconnected before suspend to prevent spurious
|
|
* wakeup.
|
|
*/
|
|
#define USB_QUIRK_DISCONNECT_SUSPEND BIT(12)
|
|
|
|
/* Device needs a pause after every control message. */
|
|
#define USB_QUIRK_DELAY_CTRL_MSG BIT(13)
|
|
|
|
/* Hub needs extra delay after resetting its port. */
|
|
#define USB_QUIRK_HUB_SLOW_RESET BIT(14)
|
|
|
|
/* device has endpoints that should be ignored */
|
|
#define USB_QUIRK_ENDPOINT_IGNORE BIT(15)
|
|
|
|
/* short SET_ADDRESS request timeout */
|
|
#define USB_QUIRK_SHORT_SET_ADDRESS_REQ_TIMEOUT BIT(16)
|
|
|
|
#endif /* __LINUX_USB_QUIRKS_H */
|