Jamie Bainbridge a699781c79 ethtool: check device is present when getting link settings ... A sysfs reader can race with a device reset or removal, attempting to read device state when the device is not actually present. eg: [exception RIP: qed_get_current_link+17] #8 [ffffb9e4f2907c48] qede_get_link_ksettings at ffffffffc07a994a [qede] #9 [ffffb9e4f2907cd8] __rh_call_get_link_ksettings at ffffffff992b01a3 #10 [ffffb9e4f2907d38] __ethtool_get_link_ksettings at ffffffff992b04e4 #11 [ffffb9e4f2907d90] duplex_show at ffffffff99260300 #12 [ffffb9e4f2907e38] dev_attr_show at ffffffff9905a01c #13 [ffffb9e4f2907e50] sysfs_kf_seq_show at ffffffff98e0145b #14 [ffffb9e4f2907e68] seq_read at ffffffff98d902e3 #15 [ffffb9e4f2907ec8] vfs_read at ffffffff98d657d1 #16 [ffffb9e4f2907f00] ksys_read at ffffffff98d65c3f #17 [ffffb9e4f2907f38] do_syscall_64 at ffffffff98a052fb crash> struct net_device.state ffff9a9d21336000 state = 5, state 5 is __LINK_STATE_START (0b1) and __LINK_STATE_NOCARRIER (0b100). The device is not present, note lack of __LINK_STATE_PRESENT (0b10). This is the same sort of panic as observed in commit 4224cfd7fb ("net-sysfs: add check for netdevice being present to speed_show"). There are many other callers of __ethtool_get_link_ksettings() which don't have a device presence check. Move this check into ethtool to protect all callers. Fixes: d519e17e2d ("net: export device speed and duplex via sysfs") Fixes: 4224cfd7fb ("net-sysfs: add check for netdevice being present to speed_show") Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com> Link: https://patch.msgid.link/8bae218864beaa44ed01628140475b9bf641c5b0.1724393671.git.jamie.bainbridge@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-08-26 14:03:02 -07:00
..
bpf_sk_storage.c
datagram.c
dev.c	net: Make USO depend on CSUM offload	2024-08-09 21:58:08 -07:00
dev.h
dev_addr_lists.c
dev_addr_lists_test.c
dev_ioctl.c
drop_monitor.c
dst.c
dst_cache.c
failover.c
fib_notifier.c
fib_rules.c
filter.c	bpf: Fix a segment issue when downgrading gso_size	2024-07-25 11:50:14 +02:00
flow_dissector.c
flow_offload.c
gen_estimator.c
gen_stats.c
gro.c
gro_cells.c
gso.c
hotdata.c
hwbm.c
ieee8021q_helpers.c
link_watch.c	net: linkwatch: use system_unbound_wq	2024-08-06 12:12:53 -07:00
lwt_bpf.c
lwtunnel.c
Makefile
neighbour.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
net-procfs.c
net-sysfs.c	ethtool: check device is present when getting link settings	2024-08-26 14:03:02 -07:00
net-sysfs.h
net-traces.c
net_namespace.c
net_test.c
netclassid_cgroup.c
netdev-genl-gen.c
netdev-genl-gen.h
netdev-genl.c
netevent.c
netpoll.c	netpoll: do not export netpoll_poll_[disable|enable]()	2024-08-21 17:31:28 -07:00
netprio_cgroup.c
of_net.c
page_pool.c
page_pool_priv.h
page_pool_user.c
pktgen.c	pktgen: use cpus_read_lock() in pg_net_init()	2024-08-22 17:14:03 -07:00
ptp_classifier.c
request_sock.c
rtnetlink.c	rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().	2024-07-29 11:36:48 +01:00
scm.c
secure_seq.c
selftests.c
skbuff.c
skmsg.c
sock.c
sock_destructor.h
sock_diag.c
sock_map.c
sock_reuseport.c
stream.c
sysctl_net_core.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
timestamping.c
tso.c
utils.c
xdp.c