Eric Dumazet bc21000e99 net_sched: sch_fq: fix incorrect behavior for small weights ... fq_dequeue() has a complex logic to find packets in one of the 3 bands. As Neal found out, it is possible that one band has a deficit smaller than its weight. fq_dequeue() can return NULL while some packets are elligible for immediate transmit. In this case, more than one iteration is needed to refill pband->credit. With default parameters (weights 589824 196608 65536) bug can trigger if large BIG TCP packets are sent to the lowest priority band. Bisected-by: John Sperbeck <jsperbeck@google.com> Diagnosed-by: Neal Cardwell <ncardwell@google.com> Fixes: 29f834aa32 ("net_sched: sch_fq: add 3 bands and WRR scheduling") Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Neal Cardwell <ncardwell@google.com> Link: https://patch.msgid.link/20240824181901.953776-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-08-27 08:20:45 -07:00
..
act_api.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-06-20 13:49:59 -07:00
act_bpf.c	net: Rename mono_delivery_time to tstamp_type for scalabilty	2024-05-23 14:14:23 -07:00
act_connmark.c
act_csum.c
act_ct.c	sched: act_ct: take care of padding in struct zones_ht_key	2024-07-26 11:22:57 +01:00
act_ctinfo.c
act_gact.c
act_gate.c
act_ife.c
act_meta_mark.c
act_meta_skbprio.c
act_meta_skbtcindex.c
act_mirred.c
act_mpls.c
act_nat.c
act_pedit.c
act_police.c
act_sample.c	net: sched: act_sample: add action cookie to sample	2024-07-05 17:45:47 -07:00
act_simple.c
act_skbedit.c
act_skbmod.c	net/sched: act_skbmod: convert comma to semicolon	2024-07-11 17:12:15 -07:00
act_tunnel_key.c
act_vlan.c
cls_api.c
cls_basic.c
cls_bpf.c	net: Rename mono_delivery_time to tstamp_type for scalabilty	2024-05-23 14:14:23 -07:00
cls_cgroup.c
cls_flow.c
cls_flower.c	net/sched: cls_flower: propagate tca[TCA_OPTIONS] to NL_REQ_ATTR_CHECK	2024-07-15 09:14:39 -07:00
cls_fw.c
cls_matchall.c
cls_route.c
cls_u32.c
em_canid.c
em_cmp.c
em_ipset.c
em_ipt.c
em_meta.c
em_nbyte.c
em_text.c
em_u32.c
ematch.c
Kconfig
Makefile
sch_api.c	rtnetlink: do not depend on RTNL for IFLA_TXQLEN output	2024-05-07 11:14:50 +02:00
sch_blackhole.c
sch_cake.c	net_sched: cake: implement lockless cake_dump()	2024-04-19 11:34:07 +01:00
sch_cbs.c	net_sched: sch_cbs: implement lockless cbs_dump()	2024-04-19 11:34:07 +01:00
sch_choke.c	net_sched: sch_choke: implement lockless choke_dump()	2024-04-19 11:34:07 +01:00
sch_codel.c	net_sched: sch_codel: implement lockless codel_dump()	2024-04-19 11:34:07 +01:00
sch_drr.c
sch_etf.c	net_sched: sch_tfs: implement lockless etf_dump()	2024-04-19 11:34:07 +01:00
sch_ets.c	net_sched: sch_ets: implement lockless ets_dump()	2024-04-19 11:34:07 +01:00
sch_fifo.c	net_sched: sch_fifo: implement lockless __fifo_dump()	2024-04-19 11:34:07 +01:00
sch_fq.c	net_sched: sch_fq: fix incorrect behavior for small weights	2024-08-27 08:20:45 -07:00
sch_fq_codel.c	net_sched: sch_fq_codel: implement lockless fq_codel_dump()	2024-04-19 11:34:07 +01:00
sch_fq_pie.c	net_sched: sch_fq_pie: implement lockless fq_pie_dump()	2024-04-19 11:34:07 +01:00
sch_frag.c
sch_generic.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-06-13 13:13:46 -07:00
sch_gred.c
sch_hfsc.c	net_sched: sch_hfsc: implement lockless accesses to q->defcls	2024-04-19 11:34:08 +01:00
sch_hhf.c	net_sched: sch_hhf: implement lockless hhf_dump()	2024-04-19 11:34:08 +01:00
sch_htb.c	net/sched: fix false lockdep warning on qdisc root lock	2024-04-26 10:46:41 +02:00
sch_ingress.c	bpf: Fix too early release of tcx_entry	2024-07-08 14:07:31 -07:00
sch_mq.c
sch_mqprio.c
sch_mqprio_lib.c
sch_mqprio_lib.h
sch_multiq.c	net: sched: sch_multiq: fix possible OOB write in multiq_tune()	2024-06-05 10:50:19 +01:00
sch_netem.c	netem: fix return value if duplicate enqueue fails	2024-08-20 17:03:34 -07:00
sch_pie.c	net_sched: sch_pie: implement lockless pie_dump()	2024-04-19 11:34:08 +01:00
sch_plug.c
sch_prio.c
sch_qfq.c
sch_red.c
sch_sfb.c
sch_sfq.c	net_sched: sch_sfq: annotate data-races around q->perturb_period	2024-05-02 19:01:35 -07:00
sch_skbprio.c	net_sched: sch_skbprio: implement lockless skbprio_dump()	2024-04-19 11:34:08 +01:00
sch_taprio.c	net: Add struct kernel_ethtool_ts_info	2024-07-15 08:02:26 -07:00
sch_tbf.c
sch_teql.c	net: annotate writes on dev->mtu from ndo_change_mtu()	2024-05-07 16:19:14 -07:00