Lorenzo Bianconi 3e705251d9 net: netfilter: move nf flowtable bpf initialization in nf_flow_table_module_init() ... Move nf flowtable bpf initialization in nf_flow_table module load routine since nf_flow_table_bpf is part of nf_flow_table module and not nf_flow_table_inet one. This patch allows to avoid the following kernel warning running the reproducer below: $modprobe nf_flow_table_inet $rmmod nf_flow_table_inet $modprobe nf_flow_table_inet modprobe: ERROR: could not insert 'nf_flow_table_inet': Invalid argument [ 184.081501] ------------[ cut here ]------------ [ 184.081527] WARNING: CPU: 0 PID: 1362 at kernel/bpf/btf.c:8206 btf_populate_kfunc_set+0x23c/0x330 [ 184.081550] CPU: 0 UID: 0 PID: 1362 Comm: modprobe Kdump: loaded Not tainted 6.11.0-0.rc5.22.el10.x86_64 #1 [ 184.081553] Hardware name: Red Hat OpenStack Compute, BIOS 1.14.0-1.module+el8.4.0+8855+a9e237a9 04/01/2014 [ 184.081554] RIP: 0010:btf_populate_kfunc_set+0x23c/0x330 [ 184.081558] RSP: 0018:ff22cfb38071fc90 EFLAGS: 00010202 [ 184.081559] RAX: 0000000000000001 RBX: 0000000000000001 RCX: 0000000000000000 [ 184.081560] RDX: 000000000000006e RSI: ffffffff95c00000 RDI: ff13805543436350 [ 184.081561] RBP: ffffffffc0e22180 R08: ff13805543410808 R09: 000000000001ec00 [ 184.081562] R10: ff13805541c8113c R11: 0000000000000010 R12: ff13805541b83c00 [ 184.081563] R13: ff13805543410800 R14: 0000000000000001 R15: ffffffffc0e2259a [ 184.081564] FS: 00007fa436c46740(0000) GS:ff1380557ba00000(0000) knlGS:0000000000000000 [ 184.081569] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 184.081570] CR2: 000055e7b3187000 CR3: 0000000100c48003 CR4: 0000000000771ef0 [ 184.081571] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 184.081572] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 184.081572] PKRU: 55555554 [ 184.081574] Call Trace: [ 184.081575] <TASK> [ 184.081578] ? show_trace_log_lvl+0x1b0/0x2f0 [ 184.081580] ? show_trace_log_lvl+0x1b0/0x2f0 [ 184.081582] ? __register_btf_kfunc_id_set+0x199/0x200 [ 184.081585] ? btf_populate_kfunc_set+0x23c/0x330 [ 184.081586] ? __warn.cold+0x93/0xed [ 184.081590] ? btf_populate_kfunc_set+0x23c/0x330 [ 184.081592] ? report_bug+0xff/0x140 [ 184.081594] ? handle_bug+0x3a/0x70 [ 184.081596] ? exc_invalid_op+0x17/0x70 [ 184.081597] ? asm_exc_invalid_op+0x1a/0x20 [ 184.081601] ? btf_populate_kfunc_set+0x23c/0x330 [ 184.081602] __register_btf_kfunc_id_set+0x199/0x200 [ 184.081605] ? __pfx_nf_flow_inet_module_init+0x10/0x10 [nf_flow_table_inet] [ 184.081607] do_one_initcall+0x58/0x300 [ 184.081611] do_init_module+0x60/0x230 [ 184.081614] __do_sys_init_module+0x17a/0x1b0 [ 184.081617] do_syscall_64+0x7d/0x160 [ 184.081620] ? __count_memcg_events+0x58/0xf0 [ 184.081623] ? handle_mm_fault+0x234/0x350 [ 184.081626] ? do_user_addr_fault+0x347/0x640 [ 184.081630] ? clear_bhb_loop+0x25/0x80 [ 184.081633] ? clear_bhb_loop+0x25/0x80 [ 184.081634] ? clear_bhb_loop+0x25/0x80 [ 184.081637] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 184.081639] RIP: 0033:0x7fa43652e4ce [ 184.081647] RSP: 002b:00007ffe8213be18 EFLAGS: 00000246 ORIG_RAX: 00000000000000af [ 184.081649] RAX: ffffffffffffffda RBX: 000055e7b3176c20 RCX: 00007fa43652e4ce [ 184.081650] RDX: 000055e7737fde79 RSI: 0000000000003990 RDI: 000055e7b3185380 [ 184.081651] RBP: 000055e7737fde79 R08: 0000000000000007 R09: 000055e7b3179bd0 [ 184.081651] R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000040000 [ 184.081652] R13: 000055e7b3176fa0 R14: 0000000000000000 R15: 000055e7b3179b80 Fixes: 391bb6594f ("netfilter: Add bpf_xdp_flow_lookup kfunc") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Acked-by: Florian Westphal <fw@strlen.de> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org> Link: https://patch.msgid.link/20240911-nf-flowtable-bpf-modprob-fix-v1-1-f9fc075aafc3@kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>		2024-09-12 15:41:03 +02:00
..
ipset	netfilter: ipset: Fix suspicious rcu_dereference_protected()	2024-06-19 15:12:56 +02:00
ipvs	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
core.c	netfilter: move the sysctl nf_hooks_lwtunnel into the netfilter core	2024-06-19 18:41:59 +02:00
Kconfig
Makefile	netfilter: Add bpf_xdp_flow_lookup kfunc	2024-07-01 17:03:01 +02:00
nf_bpf_link.c
nf_conncount.c	netfilter: nf_conncount: fix wrong variable type	2024-06-26 00:54:53 +02:00
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_bpf.c	net: netfilter: Make ct zone opts configurable for bpf ct helpers	2024-05-22 15:00:56 -07:00
nf_conntrack_broadcast.c
nf_conntrack_core.c	kernel-wide: fix spelling mistakes like "assocative" -> "associative"	2024-06-28 19:36:28 -07:00
nf_conntrack_ecache.c
nf_conntrack_expect.c	netfilter: expect: Simplify the allocation of slab caches in nf_conntrack_expect_init	2024-02-21 11:57:11 +01:00
nf_conntrack_extend.c
nf_conntrack_ftp.c
nf_conntrack_h323_asn1.c	netfilter: nf_conntrack_h323: Add protection for bmp length out of range	2024-03-07 03:10:35 +01:00
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c
nf_conntrack_irc.c
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c	netfilter: ctnetlink: use helper function to calculate expect ID	2024-07-17 19:00:47 +02:00
nf_conntrack_ovs.c
nf_conntrack_pptp.c
nf_conntrack_proto.c
nf_conntrack_proto_dccp.c	netfilter: conntrack: dccp: try not to drop skb in conntrack	2024-05-06 11:13:56 +02:00
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c
nf_conntrack_proto_icmp.c
nf_conntrack_proto_icmpv6.c	netfilter: conntrack: fix ct-state for ICMPv6 Multicast Router Discovery	2024-05-06 11:13:56 +02:00
nf_conntrack_proto_sctp.c
nf_conntrack_proto_tcp.c
nf_conntrack_proto_udp.c
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c
nf_conntrack_snmp.c
nf_conntrack_standalone.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_dup_netdev.c
nf_flow_table_bpf.c	netfilter: Add bpf_xdp_flow_lookup kfunc	2024-07-01 17:03:01 +02:00
nf_flow_table_core.c	net: netfilter: move nf flowtable bpf initialization in nf_flow_table_module_init()	2024-09-12 15:41:03 +02:00
nf_flow_table_inet.c	net: netfilter: move nf flowtable bpf initialization in nf_flow_table_module_init()	2024-09-12 15:41:03 +02:00
nf_flow_table_ip.c	netfilter: flowtable: validate vlan header	2024-08-22 12:14:18 +02:00
nf_flow_table_offload.c	netfilter: flowtable: initialise extack before use	2024-08-14 23:37:16 +02:00
nf_flow_table_procfs.c
nf_flow_table_xdp.c	netfilter: nf_tables: Add flowtable map for xdp offload	2024-07-01 17:01:53 +02:00
nf_hooks_lwtunnel.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
nf_internals.h	netfilter: move the sysctl nf_hooks_lwtunnel into the netfilter core	2024-06-19 18:41:59 +02:00
nf_log.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
nf_log_syslog.c
nf_nat_amanda.c
nf_nat_bpf.c
nf_nat_core.c	netfilter: nat: restore default DNAT behavior	2024-02-15 00:20:00 +01:00
nf_nat_ftp.c
nf_nat_helper.c
nf_nat_irc.c
nf_nat_masquerade.c
nf_nat_ovs.c
nf_nat_proto.c
nf_nat_redirect.c
nf_nat_sip.c
nf_nat_tftp.c
nf_queue.c	netfilter: move nf_reinject into nfnetlink_queue modules	2024-02-21 12:03:22 +01:00
nf_sockopt.c
nf_synproxy_core.c	ipv6: annotate data-races around cnf.hop_limit	2024-03-01 08:42:31 +00:00
nf_tables_api.c	netfilter: nf_tables: Add locking for NFT_MSG_GETOBJ_RESET requests	2024-08-14 23:44:55 +02:00
nf_tables_core.c
nf_tables_offload.c	netfilter: nf_tables: do not store nft_ctx in transaction objects	2024-06-25 20:40:47 +02:00
nf_tables_trace.c	net: add and use skb_get_hash_net	2024-06-12 14:33:38 -07:00
nfnetlink.c	netfilter: nfnetlink: Initialise extack before use in ACKs	2024-08-14 23:27:38 +02:00
nfnetlink_acct.c
nfnetlink_cthelper.c
nfnetlink_cttimeout.c	netfilter: cttimeout: remove 'l3num' attr check	2024-06-26 00:54:53 +02:00
nfnetlink_hook.c
nfnetlink_log.c
nfnetlink_osf.c
nfnetlink_queue.c	netfilter: nf_queue: drop packets with cloned unconfirmed conntracks	2024-08-14 23:37:23 +02:00
nft_bitwise.c
nft_byteorder.c
nft_chain_filter.c	netfilter: nf_tables: remove NETDEV_CHANGENAME from netdev chain event handler	2024-05-06 11:13:55 +02:00
nft_chain_nat.c
nft_chain_route.c
nft_cmp.c
nft_compat.c	netfilter: nf_tables: allow NFPROTO_INET in nft_(match/target)_validate()	2024-02-28 23:52:55 +01:00
nft_connlimit.c	netfilter: nf_tables: allow clone callbacks to sleep	2024-05-10 11:13:45 +02:00
nft_counter.c	netfilter: nft_counter: Synchronize nft_counter_reset() against reader.	2024-08-20 12:26:36 +02:00
nft_ct.c	Core x86 changes for v6.9:	2024-03-11 19:53:15 -07:00
nft_ct_fast.c
nft_dup_netdev.c
nft_dynset.c	netfilter: nf_tables: allow clone callbacks to sleep	2024-05-10 11:13:45 +02:00
nft_exthdr.c
nft_fib.c	netfilter: nft_fib: allow from forward/input without iif selector	2024-05-29 00:37:51 +02:00
nft_fib_inet.c
nft_fib_netdev.c
nft_flow_offload.c	netfilter: nf_tables: fix bidirectional offload regression	2024-02-15 00:20:00 +01:00
nft_fwd_netdev.c
nft_hash.c	net: add and use __skb_get_hash_symmetric_net	2024-06-12 14:33:38 -07:00
nft_immediate.c	netfilter: nf_tables: pass nft_chain to destroy function, not nft_ctx	2024-06-25 20:40:47 +02:00
nft_inner.c
nft_last.c	netfilter: nf_tables: allow clone callbacks to sleep	2024-05-10 11:13:45 +02:00
nft_limit.c	netfilter: nf_tables: allow clone callbacks to sleep	2024-05-10 11:13:45 +02:00
nft_log.c
nft_lookup.c	netfilter: nf_tables: fully validate NFT_DATA_VALUE on store to data registers	2024-06-27 01:09:51 +02:00
nft_masq.c
nft_meta.c	netfilter: nft_inner: validate mandatory meta and payload	2024-06-11 18:46:04 +02:00
nft_nat.c
nft_numgen.c
nft_objref.c
nft_osf.c	netfilter: nft_osf: simplify init path	2024-02-21 11:57:11 +01:00
nft_payload.c	netfilter: nft_inner: validate mandatory meta and payload	2024-06-11 18:46:04 +02:00
nft_queue.c
nft_quota.c	netfilter: nf_tables: allow clone callbacks to sleep	2024-05-10 11:13:45 +02:00
nft_range.c
nft_redir.c
nft_reject.c
nft_reject_inet.c
nft_reject_netdev.c
nft_rt.c	inet: introduce dst_rtable() helper	2024-04-30 18:32:38 -07:00
nft_set_bitmap.c	netfilter: nf_tables: restore set elements when delete set fails	2024-04-17 17:43:11 +02:00
nft_set_hash.c	netfilter: nf_tables: restore set elements when delete set fails	2024-04-17 17:43:11 +02:00
nft_set_pipapo.c	netfilter: nf_set_pipapo: fix initial map fill	2024-07-17 19:00:47 +02:00
nft_set_pipapo.h	netfilter: nf_set_pipapo: fix initial map fill	2024-07-17 19:00:47 +02:00
nft_set_pipapo_avx2.c	netfilter: nft_set_pipapo_avx2: disable softinterrupts	2024-07-24 10:01:59 +02:00
nft_set_pipapo_avx2.h
nft_set_rbtree.c	netfilter: nf_tables: restore set elements when delete set fails	2024-04-17 17:43:11 +02:00
nft_socket.c	netfilter: nft_socket: make cgroupsv2 matching work with namespaces	2024-09-12 00:16:58 +02:00
nft_synproxy.c
nft_tproxy.c
nft_tunnel.c	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
nft_xfrm.c
utils.c	netfilter: move nf_reinject into nfnetlink_queue modules	2024-02-21 12:03:22 +01:00
x_tables.c	netfilter: x_tables: Use unsafe_memcpy() for 0-sized destination	2024-02-21 12:03:22 +01:00
xt_addrtype.c
xt_AUDIT.c
xt_bpf.c
xt_cgroup.c
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c
xt_dccp.c
xt_devgroup.c
xt_dscp.c
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c
xt_helper.c
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c
xt_LOG.c
xt_mac.c
xt_mark.c
xt_MASQUERADE.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_RATEEST.c
xt_rateest.c
xt_realm.c
xt_recent.c	netfilter: xt_recent: Lift restrictions on max hitcount value	2024-06-28 17:57:50 +02:00
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c
xt_SECMARK.c
xt_set.c
xt_socket.c
xt_state.c
xt_statistic.c
xt_string.c
xt_TCPMSS.c
xt_tcpmss.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c