Eric Dumazet 2191a54f63 sched: act_ct: take care of padding in struct zones_ht_key ... Blamed commit increased lookup key size from 2 bytes to 16 bytes, because zones_ht_key got a struct net pointer. Make sure rhashtable_lookup() is not using the padding bytes which are not initialized. BUG: KMSAN: uninit-value in rht_ptr_rcu include/linux/rhashtable.h:376 [inline] BUG: KMSAN: uninit-value in __rhashtable_lookup include/linux/rhashtable.h:607 [inline] BUG: KMSAN: uninit-value in rhashtable_lookup include/linux/rhashtable.h:646 [inline] BUG: KMSAN: uninit-value in rhashtable_lookup_fast include/linux/rhashtable.h:672 [inline] BUG: KMSAN: uninit-value in tcf_ct_flow_table_get+0x611/0x2260 net/sched/act_ct.c:329 rht_ptr_rcu include/linux/rhashtable.h:376 [inline] __rhashtable_lookup include/linux/rhashtable.h:607 [inline] rhashtable_lookup include/linux/rhashtable.h:646 [inline] rhashtable_lookup_fast include/linux/rhashtable.h:672 [inline] tcf_ct_flow_table_get+0x611/0x2260 net/sched/act_ct.c:329 tcf_ct_init+0xa67/0x2890 net/sched/act_ct.c:1408 tcf_action_init_1+0x6cc/0xb30 net/sched/act_api.c:1425 tcf_action_init+0x458/0xf00 net/sched/act_api.c:1488 tcf_action_add net/sched/act_api.c:2061 [inline] tc_ctl_action+0x4be/0x19d0 net/sched/act_api.c:2118 rtnetlink_rcv_msg+0x12fc/0x1410 net/core/rtnetlink.c:6647 netlink_rcv_skb+0x375/0x650 net/netlink/af_netlink.c:2550 rtnetlink_rcv+0x34/0x40 net/core/rtnetlink.c:6665 netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline] netlink_unicast+0xf52/0x1260 net/netlink/af_netlink.c:1357 netlink_sendmsg+0x10da/0x11e0 net/netlink/af_netlink.c:1901 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 ____sys_sendmsg+0x877/0xb60 net/socket.c:2597 ___sys_sendmsg+0x28d/0x3c0 net/socket.c:2651 __sys_sendmsg net/socket.c:2680 [inline] __do_sys_sendmsg net/socket.c:2689 [inline] __se_sys_sendmsg net/socket.c:2687 [inline] __x64_sys_sendmsg+0x307/0x4a0 net/socket.c:2687 x64_sys_call+0x2dd6/0x3c10 arch/x86/include/generated/asm/syscalls_64.h:47 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Local variable key created at: tcf_ct_flow_table_get+0x4a/0x2260 net/sched/act_ct.c:324 tcf_ct_init+0xa67/0x2890 net/sched/act_ct.c:1408 Fixes: 88c67aeb14 ("sched: act_ct: add netns into the key of tcf_ct_flow_table") Reported-by: syzbot+1b5e4e187cc586d05ea0@syzkaller.appspotmail.com Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Xin Long <lucien.xin@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: Xin Long <lucien.xin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2024-07-26 11:22:57 +01:00
..
act_api.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-06-20 13:49:59 -07:00
act_bpf.c	net: Rename mono_delivery_time to tstamp_type for scalabilty	2024-05-23 14:14:23 -07:00
act_connmark.c
act_csum.c
act_ct.c	sched: act_ct: take care of padding in struct zones_ht_key	2024-07-26 11:22:57 +01:00
act_ctinfo.c
act_gact.c
act_gate.c
act_ife.c
act_meta_mark.c
act_meta_skbprio.c
act_meta_skbtcindex.c
act_mirred.c
act_mpls.c
act_nat.c
act_pedit.c
act_police.c
act_sample.c	net: sched: act_sample: add action cookie to sample	2024-07-05 17:45:47 -07:00
act_simple.c
act_skbedit.c
act_skbmod.c	net/sched: act_skbmod: convert comma to semicolon	2024-07-11 17:12:15 -07:00
act_tunnel_key.c
act_vlan.c
cls_api.c	net: sched: cls_api: fix slab-use-after-free in fl_dump_key	2024-04-10 08:28:26 +01:00
cls_basic.c
cls_bpf.c	net: Rename mono_delivery_time to tstamp_type for scalabilty	2024-05-23 14:14:23 -07:00
cls_cgroup.c
cls_flow.c
cls_flower.c	net/sched: cls_flower: propagate tca[TCA_OPTIONS] to NL_REQ_ATTR_CHECK	2024-07-15 09:14:39 -07:00
cls_fw.c
cls_matchall.c
cls_route.c
cls_u32.c
em_canid.c
em_cmp.c
em_ipset.c
em_ipt.c
em_meta.c
em_nbyte.c
em_text.c
em_u32.c
ematch.c
Kconfig
Makefile
sch_api.c	rtnetlink: do not depend on RTNL for IFLA_TXQLEN output	2024-05-07 11:14:50 +02:00
sch_blackhole.c
sch_cake.c	net_sched: cake: implement lockless cake_dump()	2024-04-19 11:34:07 +01:00
sch_cbs.c	net_sched: sch_cbs: implement lockless cbs_dump()	2024-04-19 11:34:07 +01:00
sch_choke.c	net_sched: sch_choke: implement lockless choke_dump()	2024-04-19 11:34:07 +01:00
sch_codel.c	net_sched: sch_codel: implement lockless codel_dump()	2024-04-19 11:34:07 +01:00
sch_drr.c
sch_etf.c	net_sched: sch_tfs: implement lockless etf_dump()	2024-04-19 11:34:07 +01:00
sch_ets.c	net_sched: sch_ets: implement lockless ets_dump()	2024-04-19 11:34:07 +01:00
sch_fifo.c	net_sched: sch_fifo: implement lockless __fifo_dump()	2024-04-19 11:34:07 +01:00
sch_fq.c	net_sched: sch_fq: implement lockless fq_dump()	2024-04-19 11:34:07 +01:00
sch_fq_codel.c	net_sched: sch_fq_codel: implement lockless fq_codel_dump()	2024-04-19 11:34:07 +01:00
sch_fq_pie.c	net_sched: sch_fq_pie: implement lockless fq_pie_dump()	2024-04-19 11:34:07 +01:00
sch_frag.c
sch_generic.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-06-13 13:13:46 -07:00
sch_gred.c
sch_hfsc.c	net_sched: sch_hfsc: implement lockless accesses to q->defcls	2024-04-19 11:34:08 +01:00
sch_hhf.c	net_sched: sch_hhf: implement lockless hhf_dump()	2024-04-19 11:34:08 +01:00
sch_htb.c	net/sched: fix false lockdep warning on qdisc root lock	2024-04-26 10:46:41 +02:00
sch_ingress.c	bpf: Fix too early release of tcx_entry	2024-07-08 14:07:31 -07:00
sch_mq.c
sch_mqprio.c
sch_mqprio_lib.c
sch_mqprio_lib.h
sch_multiq.c	net: sched: sch_multiq: fix possible OOB write in multiq_tune()	2024-06-05 10:50:19 +01:00
sch_netem.c
sch_pie.c	net_sched: sch_pie: implement lockless pie_dump()	2024-04-19 11:34:08 +01:00
sch_plug.c
sch_prio.c
sch_qfq.c
sch_red.c
sch_sfb.c
sch_sfq.c	net_sched: sch_sfq: annotate data-races around q->perturb_period	2024-05-02 19:01:35 -07:00
sch_skbprio.c	net_sched: sch_skbprio: implement lockless skbprio_dump()	2024-04-19 11:34:08 +01:00
sch_taprio.c	net: Add struct kernel_ethtool_ts_info	2024-07-15 08:02:26 -07:00
sch_tbf.c
sch_teql.c	net: annotate writes on dev->mtu from ndo_change_mtu()	2024-05-07 16:19:14 -07:00