Dmitry Kasatkin 40b50e80c5 KEYS: handle error code encoded in pointer ... If hexlen is odd then function returns an error. Use IS_ERR to check for error, otherwise invalid pointer is used and kernel gives oops: [ 132.816522] BUG: unable to handle kernel paging request at ffffffffffffffea [ 132.819902] IP: [<ffffffff812bfc20>] asymmetric_key_id_same+0x14/0x36 [ 132.820302] PGD 1a12067 PUD 1a14067 PMD 0 [ 132.820302] Oops: 0000 [#1] SMP [ 132.820302] Modules linked in: bridge(E) stp(E) llc(E) evdev(E) serio_raw(E) i2c_piix4(E) button(E) fuse(E) [ 132.820302] CPU: 0 PID: 2993 Comm: cat Tainted: G E 3.16.0-kds+ #2847 [ 132.820302] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 132.820302] task: ffff88004249a430 ti: ffff880056640000 task.ti: ffff880056640000 [ 132.820302] RIP: 0010:[<ffffffff812bfc20>] [<ffffffff812bfc20>] asymmetric_key_id_same+0x14/0x36 [ 132.820302] RSP: 0018:ffff880056643930 EFLAGS: 00010246 [ 132.820302] RAX: 0000000000000000 RBX: ffffffffffffffea RCX: ffff880056643ae0 [ 132.820302] RDX: 000000000000005e RSI: ffffffffffffffea RDI: ffff88005bac9300 [ 132.820302] RBP: ffff880056643948 R08: 0000000000000003 R09: 00000007504aa01a [ 132.820302] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88005d68ca40 [ 132.820302] R13: 0000000000000101 R14: 0000000000000000 R15: ffff88005bac5280 [ 132.820302] FS: 00007f67a153c740(0000) GS:ffff88005da00000(0000) knlGS:0000000000000000 [ 132.820302] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 132.820302] CR2: ffffffffffffffea CR3: 000000002e663000 CR4: 00000000000006f0 [ 132.820302] Stack: [ 132.820302] ffffffff812bfc66 ffff880056643ae0 ffff88005bac5280 ffff880056643958 [ 132.820302] ffffffff812bfc9d ffff880056643980 ffffffff812971d9 ffff88005ce930c1 [ 132.820302] ffff88005ce930c0 0000000000000000 ffff8800566439c8 ffffffff812fb753 [ 132.820302] Call Trace: [ 132.820302] [<ffffffff812bfc66>] ? asymmetric_match_key_ids+0x24/0x42 [ 132.820302] [<ffffffff812bfc9d>] asymmetric_key_cmp+0x19/0x1b [ 132.820302] [<ffffffff812971d9>] keyring_search_iterator+0x74/0xd7 [ 132.820302] [<ffffffff812fb753>] assoc_array_subtree_iterate+0x67/0xd2 [ 132.820302] [<ffffffff81297165>] ? key_default_cmp+0x20/0x20 [ 132.820302] [<ffffffff812fbaa1>] assoc_array_iterate+0x19/0x1e [ 132.820302] [<ffffffff81297332>] search_nested_keyrings+0xf6/0x2b6 [ 132.820302] [<ffffffff810728da>] ? sched_clock_cpu+0x91/0xa2 [ 132.820302] [<ffffffff810860d2>] ? mark_held_locks+0x58/0x6e [ 132.820302] [<ffffffff810a137d>] ? current_kernel_time+0x77/0xb8 [ 132.820302] [<ffffffff81297871>] keyring_search_aux+0xe1/0x14c [ 132.820302] [<ffffffff812977fc>] ? keyring_search_aux+0x6c/0x14c [ 132.820302] [<ffffffff8129796b>] keyring_search+0x8f/0xb6 [ 132.820302] [<ffffffff812bfc84>] ? asymmetric_match_key_ids+0x42/0x42 [ 132.820302] [<ffffffff81297165>] ? key_default_cmp+0x20/0x20 [ 132.820302] [<ffffffff812ab9e3>] asymmetric_verify+0xa4/0x214 [ 132.820302] [<ffffffff812ab90e>] integrity_digsig_verify+0xb1/0xe2 [ 132.820302] [<ffffffff812abe41>] ? evm_verifyxattr+0x6a/0x7a [ 132.820302] [<ffffffff812b0390>] ima_appraise_measurement+0x160/0x370 [ 132.820302] [<ffffffff81161db2>] ? d_absolute_path+0x5b/0x7a [ 132.820302] [<ffffffff812ada30>] process_measurement+0x322/0x404 Reported-by: Dmitry Kasatkin <d.kasatkin@samsung.com> Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com> Signed-off-by: David Howells <dhowells@redhat.com>		2014-10-03 13:41:51 +01:00
..
asymmetric_keys	KEYS: handle error code encoded in pointer	2014-10-03 13:41:51 +01:00
async_tx	Merge commit 'dmaengine-3.13-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/djbw/dmaengine	2013-11-16 12:02:36 +05:30
842.c
ablk_helper.c	crypto: ablk_helper - Replace memcpy with struct assignment	2013-10-07 14:16:57 +08:00
ablkcipher.c	crypto: skcipher - Use eseqiv even on UP machines	2013-10-30 09:51:45 +08:00
aead.c
aes_generic.c	crypto: make tables used from assembler __visible	2013-08-14 20:42:03 +10:00
af_alg.c	crypto: af_alg - properly label AF_ALG socket	2014-07-31 21:54:00 +08:00
ahash.c	crypto: hash - Add real ahash walk interface	2014-05-21 20:56:12 +08:00
algapi.c	crypto: sanitize argument for format string	2013-07-03 16:07:25 -07:00
algboss.c	crypto: algboss - Hold ref count on larval	2013-06-25 19:15:17 +08:00
algif_hash.c	net: update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST	2013-11-29 16:32:54 -05:00
algif_skcipher.c	net: update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST	2013-11-29 16:32:54 -05:00
ansi_cprng.c	crypto: ansi_cprng - Fix off by one error in non-block size request	2013-09-24 06:02:23 +10:00
anubis.c
api.c	crypto: api - Fix race condition in larval lookup	2013-09-08 14:33:50 +10:00
arc4.c
authenc.c	crypto: authenc - Find proper IV address in ablkcipher callback	2013-11-28 22:16:23 +08:00
authencesn.c	crypto: authencesn - Simplify key parsing	2013-10-16 20:56:25 +08:00
blkcipher.c	crypto: allow blkcipher walks over AEAD data	2014-03-10 20:17:11 +08:00
blowfish_common.c
blowfish_generic.c
camellia_generic.c	crypto: camellia_generic - replace commas by semicolons and adjust code alignment	2013-08-21 21:08:33 +10:00
cast5_generic.c
cast6_generic.c
cast_common.c	crypto: make tables used from assembler __visible	2013-08-14 20:42:03 +10:00
cbc.c
ccm.c	crypto: ccm - Fix handling of zero plaintext when computing mac	2013-11-28 22:25:17 +08:00
chainiv.c	arch: Mass conversion of smp_mb__*()	2014-04-18 14:20:48 +02:00
cipher.c
cmac.c	crypto: add CMAC support to CryptoAPI	2013-04-25 21:01:47 +08:00
compress.c
crc32.c
crc32c_generic.c	CRC32C: Add soft module dependency to load other accelerated crc32c modules	2014-02-25 19:45:04 +08:00
crct10dif_common.c	crypto: crct10dif - Add fallback for broken initrds	2013-09-12 15:31:34 +10:00
crct10dif_generic.c	crypto: crct10dif - Add fallback for broken initrds	2013-09-12 15:31:34 +10:00
cryptd.c
crypto_null.c	crypto: export NULL algorithms defines	2014-03-21 21:54:26 +08:00
crypto_user.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6 into next	2014-06-07 19:44:40 -07:00
crypto_wq.c	crypto: crypto_wq - Fix late crypto work queue initialization	2014-03-21 21:54:28 +08:00
ctr.c
cts.c
deflate.c
des_generic.c
ecb.c
eseqiv.c
fcrypt.c	crypto: fcrypt - Fix bitoperation for compilation with clang	2013-09-02 20:32:58 +10:00
fips.c
gcm.c	crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks	2013-10-07 14:17:06 +08:00
gf128mul.c
ghash-generic.c
hash_info.c	crypto: provide single place for hash algo information	2013-10-25 17:14:03 -04:00
hmac.c
internal.h	crypto: algboss - Hold ref count on larval	2013-06-25 19:15:17 +08:00
Kconfig	crypto: sha - SHA1 transform x86_64 AVX2	2014-03-21 21:54:30 +08:00
khazad.c
krng.c
lrw.c
lz4.c	crypto: add lz4 Cryptographic API	2013-07-09 10:33:30 -07:00
lz4hc.c	crypto: add lz4 Cryptographic API	2013-07-09 10:33:30 -07:00
lzo.c
Makefile	CRC32C: Add soft module dependency to load other accelerated crc32c modules	2014-02-25 19:45:04 +08:00
md4.c
md5.c
memneq.c	crypto: memneq - fix for archs without efficient unaligned access	2013-12-09 20:09:12 +08:00
michael_mic.c
pcbc.c
pcompress.c
pcrypt.c	crypto: pcrypt - Fix wrong usage of rcu_dereference()	2013-12-05 21:28:42 +08:00
proc.c
ripemd.h
rmd128.c
rmd160.c
rmd256.c
rmd320.c
rng.c
salsa20_generic.c
scatterwalk.c	crypto: scatterwalk - Add support for calculating number of SG elements	2013-08-21 21:27:58 +10:00
seed.c
seqiv.c
serpent_generic.c
sha1_generic.c
sha256_generic.c	crypto: sha256 - Expose SHA256 generic routine to be callable externally.	2013-04-03 09:06:31 +08:00
sha512_generic.c	crypto: sha512_generic - set cra_driver_name	2013-05-28 15:43:04 +08:00
shash.c	crypto: LLVMLinux: aligned-attribute.patch	2014-06-07 11:44:39 -07:00
tcrypt.c	crypto: testmgr - add aead cbc des, des3_ede tests	2014-05-22 21:03:18 +08:00
tcrypt.h	crypto: tcrypt - Added speed tests for AEAD crypto alogrithms in tcrypt test suite	2013-12-20 20:06:25 +08:00
tea.c
testmgr.c	crypto: testmgr - add aead cbc des, des3_ede tests	2014-05-22 21:03:18 +08:00
testmgr.h	crypto: testmgr - add aead cbc des, des3_ede tests	2014-05-22 21:03:18 +08:00
tgr192.c
twofish_common.c
twofish_generic.c
vmac.c
wp512.c
xcbc.c
xor.c
xts.c
zlib.c