Daniel Borkmann aadd435591 tcp, ulp: remove socket lock assertion on ULP cleanup ... Eric reported that syzkaller triggered a splat in tcp_cleanup_ulp() where assertion sock_owned_by_me() failed. This happened through inet_csk_prepare_forced_close() first releasing the socket lock, then calling into tcp_done(newsk) which is called after the inet_csk_prepare_forced_close() and therefore without the socket lock held. The sock_owned_by_me() assertion can generally be removed as the only place where tcp_cleanup_ulp() is called from now is out of inet_csk_destroy_sock() -> sk->sk_prot->destroy() where socket is in dead state and unreachable. Therefore, add a comment why the check is not needed instead. Fixes: 8b9088f806 ("tcp, ulp: enforce sock_owned_by_me upon ulp init and cleanup") Reported-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-10-16 12:38:41 -07:00
..
bpfilter	bpfilter: remove trailing newline	2018-07-24 14:10:42 -07:00
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2018-10-08 21:28:55 -07:00
af_inet.c	gso_segment: Reset skb->mac_len after modifying network header	2018-09-13 12:09:32 -07:00
ah4.c	net-ipv4: remove 2 always zero parameters from ipv4_redirect()	2018-09-26 20:30:55 -07:00
arp.c	net: Evict neighbor entries on carrier down	2018-10-12 09:47:39 -07:00
cipso_ipv4.c	net/ipv4: defensive cipso option parsing	2018-09-17 19:37:46 -07:00
datagram.c	ipv4: Allow sending multicast packets on specific i/f using VRF socket	2018-10-02 22:28:17 -07:00
devinet.c	net: Update netconf dump handlers for strict data checking	2018-10-08 10:39:05 -07:00
esp4.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2018-10-01 22:31:17 -07:00
esp4_offload.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2018-07-27 09:33:37 -07:00
fib_frontend.c	net/ipv4: Bail early if user only wants prefix entries	2018-10-16 00:14:08 -07:00
fib_lookup.h
fib_notifier.c
fib_rules.c
fib_semantics.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-12 21:38:46 -07:00
fib_trie.c	net/ipv4: Plumb support for filtering route dumps	2018-10-16 00:13:12 -07:00
fou.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-07-03 10:29:26 +09:00
gre_demux.c	ip_gre: fix parsing gre header in ipgre_err	2018-09-16 15:32:59 -07:00
gre_offload.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-07-03 10:29:26 +09:00
icmp.c	net-ipv4: remove 2 always zero parameters from ipv4_redirect()	2018-09-26 20:30:55 -07:00
igmp.c	igmp: fix incorrect unsolicit report count after link down and up	2018-09-02 13:39:37 -07:00
inet_connection_sock.c	inet: make sure to grab rcu_read_lock before using ireq->ireq_opt	2018-10-02 15:52:12 -07:00
inet_diag.c
inet_fragment.c	ip: process in-order fragments efficiently	2018-08-11 17:54:18 -07:00
inet_hashtables.c	bpf: Enable BPF_PROG_TYPE_SK_REUSEPORT bpf prog in reuseport selection	2018-08-11 01:58:46 +02:00
inet_timewait_sock.c
inetpeer.c
ip_forward.c	net: ipv4: Control SKB reprioritization after forwarding	2018-08-01 09:52:30 -07:00
ip_fragment.c	net/ipfrag: let ip[6]frag_high_thresh in ns be higher than in init_net	2018-09-21 19:45:52 -07:00
ip_gre.c	net-ipv4: remove 2 always zero parameters from ipv4_redirect()	2018-09-26 20:30:55 -07:00
ip_input.c	net: Add and use skb_list_del_init().	2018-09-10 10:06:54 -07:00
ip_options.c
ip_output.c	net: Add and use skb_mark_not_on_list().	2018-09-10 10:06:54 -07:00
ip_sockglue.c	ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()	2018-10-02 22:32:05 -07:00
ip_tunnel.c	ip_tunnel: be careful when accessing the inner header	2018-09-24 12:27:04 -07:00
ip_tunnel_core.c
ip_vti.c	net-ipv4: remove 2 always zero parameters from ipv4_redirect()	2018-09-26 20:30:55 -07:00
ipcomp.c	net-ipv4: remove 2 always zero parameters from ipv4_redirect()	2018-09-26 20:30:55 -07:00
ipconfig.c
ipip.c	net-ipv4: remove 2 always zero parameters from ipv4_redirect()	2018-09-26 20:30:55 -07:00
ipmr.c	net: Enable kernel side filtering of route dumps	2018-10-16 00:14:07 -07:00
ipmr_base.c	net: Plumb support for filtering ipv4 and ipv6 multicast route dumps	2018-10-16 00:13:39 -07:00
Kconfig	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
Makefile	bpf, sockmap: convert to generic sk_msg interface	2018-10-15 12:23:19 -07:00
metrics.c	net: common metrics init helper for FIB entries	2018-10-04 21:54:03 -07:00
netfilter.c	netfilter: utils: move nf_ip_checksum* from ipv4 to utils	2018-07-16 17:51:48 +02:00
netlink.c
ping.c	ipv4: Allow sending multicast packets on specific i/f using VRF socket	2018-10-02 22:28:17 -07:00
proc.c	ip: discard IPv4 datagrams with overlapping segments.	2018-08-05 17:16:46 -07:00
protocol.c
raw.c	ipv4: Allow sending multicast packets on specific i/f using VRF socket	2018-10-02 22:28:17 -07:00
raw_diag.c
route.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-12 21:38:46 -07:00
syncookies.c	tcp: provide earliest departure time in skb->tstamp	2018-09-21 19:37:59 -07:00
sysctl_net_ipv4.c	net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int	2018-09-26 20:33:21 -07:00
tcp.c	net: extend sk_pacing_rate to unsigned long	2018-10-15 22:56:42 -07:00
tcp_bbr.c	tcp_bbr: fix typo in bbr_pacing_margin_percent	2018-10-15 22:56:42 -07:00
tcp_bic.c
tcp_bpf.c	bpf, sockmap: convert to generic sk_msg interface	2018-10-15 12:23:19 -07:00
tcp_cdg.c	tcp: cdg: use tcp high resolution clock cache	2018-10-15 22:56:42 -07:00
tcp_cong.c
tcp_cubic.c
tcp_dctcp.c	tcp: refactor DCTCP ECN ACK handling	2018-10-10 22:26:00 -07:00
tcp_dctcp.h	tcp: refactor DCTCP ECN ACK handling	2018-10-10 22:26:00 -07:00
tcp_diag.c
tcp_fastopen.c
tcp_highspeed.c
tcp_htcp.c
tcp_hybla.c
tcp_illinois.c
tcp_input.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-03 21:00:17 -07:00
tcp_ipv4.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-03 21:00:17 -07:00
tcp_lp.c
tcp_metrics.c
tcp_minisocks.c	tcp: do not restart timewait timer on rst reception	2018-08-31 23:10:35 -07:00
tcp_nv.c
tcp_offload.c	tcp: Don't coalesce decrypted and encrypted SKBs	2018-07-16 00:12:09 -07:00
tcp_output.c	tcp: optimize tcp internal pacing	2018-10-15 22:56:42 -07:00
tcp_rate.c	tcp: introduce tcp_skb_timestamp_us() helper	2018-09-21 19:37:59 -07:00
tcp_recovery.c	tcp: introduce tcp_skb_timestamp_us() helper	2018-09-21 19:37:59 -07:00
tcp_scalable.c
tcp_timer.c	tcp: do not change tcp_wstamp_ns in tcp_mstamp_refresh	2018-10-15 22:56:41 -07:00
tcp_ulp.c	tcp, ulp: remove socket lock assertion on ULP cleanup	2018-10-16 12:38:41 -07:00
tcp_vegas.c
tcp_vegas.h
tcp_veno.c
tcp_westwood.c
tcp_yeah.c
tunnel4.c
udp.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-12 21:38:46 -07:00
udp_diag.c
udp_impl.h
udp_offload.c	udp: gro behind static key	2018-10-05 11:52:38 -07:00
udp_tunnel.c
udplite.c
xfrm4_input.c	xfrm: reset transport header back to network header after all input transforms ahave been applied	2018-09-04 10:26:30 +02:00
xfrm4_mode_beet.c
xfrm4_mode_transport.c	xfrm: reset transport header back to network header after all input transforms ahave been applied	2018-09-04 10:26:30 +02:00
xfrm4_mode_tunnel.c
xfrm4_output.c
xfrm4_policy.c
xfrm4_protocol.c
xfrm4_state.c
xfrm4_tunnel.c