c71c8fd4da
The devm_kzalloc function eliminates the need for manual resource releasing and simplify error handling. Resources allocated by devm_* are freed automatically on driver detach. Thus adding kfree calls here will introduce double free bug. The memory of desc array and the pointers to the rdev[] are allocated by devm_kzalloc call for struct palmas_pmic. struct palmas_pmic { struct palmas *palmas; struct device *dev; struct regulator_desc desc[PALMAS_NUM_REGS]; struct regulator_dev *rdev[PALMAS_NUM_REGS]; struct mutex mutex; int smps123; int smps457; int range[PALMAS_REG_SMPS10]; }; Which means we should not call kfree for pmic->rdev and pmic->desc. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> |
||
---|---|---|
.. | ||
88pm8607.c | ||
aat2870-regulator.c | ||
ab3100.c | ||
ab8500.c | ||
ad5398.c | ||
anatop-regulator.c | ||
core.c | ||
da903x.c | ||
da9052-regulator.c | ||
db8500-prcmu.c | ||
dbx500-prcmu.c | ||
dbx500-prcmu.h | ||
dummy.c | ||
dummy.h | ||
fixed-helper.c | ||
fixed.c | ||
gpio-regulator.c | ||
isl6271a-regulator.c | ||
Kconfig | ||
lp3971.c | ||
lp3972.c | ||
Makefile | ||
max1586.c | ||
max8649.c | ||
max8660.c | ||
max8925-regulator.c | ||
max8952.c | ||
max8997.c | ||
max8998.c | ||
mc13xxx-regulator-core.c | ||
mc13xxx.h | ||
mc13783-regulator.c | ||
mc13892-regulator.c | ||
of_regulator.c | ||
palmas-regulator.c | ||
pcap-regulator.c | ||
pcf50633-regulator.c | ||
rc5t583-regulator.c | ||
s5m8767.c | ||
tps6105x-regulator.c | ||
tps6507x-regulator.c | ||
tps6524x-regulator.c | ||
tps6586x-regulator.c | ||
tps62360-regulator.c | ||
tps65023-regulator.c | ||
tps65090-regulator.c | ||
tps65217-regulator.c | ||
tps65910-regulator.c | ||
tps65912-regulator.c | ||
twl-regulator.c | ||
userspace-consumer.c | ||
virtual.c | ||
wm831x-dcdc.c | ||
wm831x-isink.c | ||
wm831x-ldo.c | ||
wm8350-regulator.c | ||
wm8400-regulator.c | ||
wm8994-regulator.c |